Move git-hooks #306
Merged
Move git-hooks #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-gg-dev
approved these changes
Aug 25, 2023
Chemaclass
force-pushed
the
move-git-hooks
branch
from
f7f7da8
to
ffa227c
Compare
JesusValera
approved these changes
Aug 26, 2023
There was a problem hiding this comment.
Honestly, I am not completely happy creating a tools folder.
It was like that in the past and we decided to put the init.sh inside the github folder to simplify the root, although, the github folder is not the best place as you mentioned, and I don't have other ideas at the moment, so, let's try for now with the tools folder again 👍🏼
fabriziofs
approved these changes
Aug 26, 2023
| @@ -5,8 +5,7 @@ set -e | |||
| function setup_git_hooks() | |||
| { | |||
| echo "Initialising git hooks..." | |||
| ln -sf "$PWD/.github/git-hooks/pre-commit.sh" "$PWD/.git/hooks/pre-commit" | |||
| chmod +x "$PWD/.git/hooks/pre-commit" | |||
There was a problem hiding this comment.
It's not necessary anymore to make the script executable? @Chemaclass 🧐
There was a problem hiding this comment.
Jap, it's not needed, because I made the committed file itself executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Keeping git-hooks inside the
.github/is a bit confusing, because it has nothing to do with github. Therefore, a more suitable folder name liketools/is more appropriate🔖 Changes
.github/totools/